Skip to content

test: fix deeplink and stake test flakiness#30254

Open
davibroc wants to merge 1 commit into
mainfrom
fix/trade-e2e-flaky-tests
Open

test: fix deeplink and stake test flakiness#30254
davibroc wants to merge 1 commit into
mainfrom
fix/trade-e2e-flaky-tests

Conversation

@davibroc
Copy link
Copy Markdown
Contributor

@davibroc davibroc commented May 15, 2026

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk test-only changes that broaden the e2e network allowlist for BrowserStack Local and slightly relax a UI wait to reduce flakiness.

Overview
Reduces e2e test flakiness by allowing bs-local.com traffic through the mock allowlist (to support BrowserStack Local tunnel environments).

Also increases the WalletView.earnButton visibility wait in the stake smoke test from 45s to 60s to better tolerate slower balance/mock loading.

Reviewed by Cursor Bugbot for commit d45df6e. Bugbot is set up for automated code reviews on this repo. Configure here.

@davibroc davibroc requested a review from a team as a code owner May 15, 2026 14:09
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 15, 2026
@metamaskbotv2 metamaskbotv2 Bot added the team-qa QA team label May 15, 2026
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. size-XS team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant